]> git.koha-community.org Git - koha.git/commit
Bug 10256: Remove some unused subs from Overdues module
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 16 May 2013 07:52:41 +0000 (09:52 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Mon, 17 Jun 2013 16:08:50 +0000 (09:08 -0700)
commit8f20b248e7dd6e10b019b1ec27dfb04796e9b0a5
treea5dd77c4031d8596fa9c18bb0db2ffc8bb486f28
parent6c3a28b64032d0dcad57df222c42e163385d2e98
Bug 10256: Remove some unused subs from Overdues module

Removes the following exported but unused subs from Overdues.pm:
CreateItemAccountLine
UpdateAccountLines
CheckAccountLineLevelInfo
CheckAccountLineItemInfo
CheckExistantNotifyid
GetNextIdNotify
GetNotifyId
ReplacementCost
ReplacementCost2
GetOverdueDelays
GetOverduerules

Test plan:
It is hard to test the removal of something that was not used :) Try this:
Do a recursive grep on these routine names in the Koha codebase.
Compile some scripts that use the Overdues module.
And just to be sure we do not break something:
Go to Circulation: Do a checkout, checkin, place and confirm a hold.
Go to Patrons: Goto Check out. Goto Fines.
Run the command line scripts: fines.pl and overdue_notices.pl.
Go to opac-user.pl.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Overdues.pm
t/db_dependent/lib/KohaTest/Overdues.pm