]> git.koha-community.org Git - koha.git/commit
Bug 26648: Prevent explosion in notices on missing item
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 9 Oct 2020 15:13:00 +0000 (16:13 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 5 Dec 2022 18:38:50 +0000 (18:38 +0000)
commitcb0967ae7dd5cc94b906887371982736d54323b4
treeb8723b7bfbe5738b7a0d0c47a24bbfe150bdc53e
parent0dee72d97aa2084d60d1c770ec8e55eafbc51313
Bug 26648: Prevent explosion in notices on missing item

The item accessor in Koha::Old::Checkouts could explode given a checkout
where the item had been deleted.

To test
1/ Edit the issueslip notice to output some item details from the
borrowers old checkouts

[% FOREACH old_checkout IN borrower.old_checkouts %]
  [% IF old_checkout.item %]
    [% old_checkout.item.price %]
  [% END %]
[% END %]

2/ Delete the item associated with an old checkout for a test patron
3/ Print the issueslip for the patron
4/ Note a server side error is triggered
5/ Apply the patch
6/ Print the slip again and note the price details for old checkouts are
now displayed
7/ Signoff

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 971ad5538c3026e126081376520ccb3b13c12d1c)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/Old/Checkout.pm