]> git.koha-community.org Git - koha.git/commit
Bug 9535 - Patron card creator "Remove duplicates" function doesn't work
authorChris Nighswonger <cnighswonger@foundations.edu>
Tue, 2 Apr 2013 14:05:46 +0000 (10:05 -0400)
committerChris Cormack <chrisc@catalyst.net.nz>
Sun, 14 Apr 2013 07:26:56 +0000 (19:26 +1200)
commitfed08650e436965f8ba363287c335c434f24cddf
treeb282b8487cded41766f4eb628301fc07975050f5
parent61e355c0dc2f1a3f578a4d4f77ad70bc220e3ffe
Bug 9535 - Patron card creator "Remove duplicates" function doesn't work

This bug was due to a difference in field names used in the item data
for items versus patrons. This patch adds a ternary to discern between
the two.

To test:

Before applying patch:

1. Create a batch of patroncards with one duplicate.
2. Run the de-duplication on the batch.
3. Note that all patrons beyond the first in the batch are now
   deleted.

After applying patch:
4. Repeat steps 1-2.
5. Note that only the duplicate patron is removed.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested successfully with both patron card batches and label batches.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Add indentation for readability
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Creators/Batch.pm