From 0321fd5776aec9493ef2a87e67e60bd1a4710ca5 Mon Sep 17 00:00:00 2001
From: Pasi Kallinen <pasi.kallinen@joensuu.fi>
Date: Wed, 31 Oct 2018 14:04:33 +0200
Subject: [PATCH] Bug 21736: Allow translating the localization widget messages

The widget used to translate the item type names to other
languages has few javascript messages that cannot be translated.
Add the mechanism to enable their translation.

Test plan:

1) Install and update a language
2) Check the po-files, there's no msgid for
   "A translation already exists for this language."
3) Apply the patch
4) Install and update a language
5) There should be a msgid for the one in 2, and
   couple other messages from localization.tt
6) Translate those messages, update the translated templates
7) Go to Administration -> Item types -> Modify item type ->
   Translate into other languages
   Add a new translation, check that the message given by the widget
   was in correct language.

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 5cacb502392aaebaef84339233227eb261d45277)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../prog/en/modules/admin/localization.tt        | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt
index 1eb74f9bb6..b60756dbe0 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt
@@ -64,29 +64,29 @@
             var message;
             if ( type == 'success_on_update' ) {
                 message = $('<div class="dialog message"></div>');
-                message.text("Entity %s (code %s) for lang %s has correctly been updated with '%s'".format(data.entity, data.code, data.lang, data.translation));
+                message.text(_("Entity %s (code %s) for lang %s has correctly been updated with '%s'").format(data.entity, data.code, data.lang, data.translation));
             } else if ( type == 'error_on_update' ) {
                 message = $('<div class="dialog alert"></div>');
                 if ( data.error_code == 'already_exists' ) {
-                    message.text("A translation already exists for this language.");
+                    message.text(_("A translation already exists for this language."));
                 } else {
-                    message.text("An error occurred when updating this translation.");
+                    message.text(_("An error occurred when updating this translation."));
                 }
             } else if ( type == 'success_on_delete' ) {
                 message = $('<div class="dialog message"></div>');
-                message.text("The translation (id %s) has been removed successfully".format(data.id));
+                message.text(_("The translation (id %s) has been removed successfully").format(data.id));
             } else if ( type == 'error_on_delete' ) {
                 message = $('<div class="dialog alert"></div>');
-                message.text("An error occurred when deleting this translation");
+                message.text(_("An error occurred when deleting this translation"));
             } else if ( type == 'success_on_insert' ) {
                 message = $('<div class="dialog message"></div>');
-                message.text("Translation (id %s) has been added successfully".format(data.id));
+                message.text(_("Translation (id %s) has been added successfully").format(data.id));
             } else if ( type == 'error_on_insert' ) {
                 message = $('<div class="dialog alert"></div>');
                 if ( data.error_code == 'already_exists' ) {
-                    message.text("A translation already exists for this language.");
+                    message.text(_("A translation already exists for this language."));
                 } else {
-                    message.text("An error occurred when adding this translation");
+                    message.text(_("An error occurred when adding this translation"));
                 }
             }
 
-- 
2.39.5