From 6a55fad7b42ce8a9735dabc965dfd524899e4e71 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Fri, 7 Jul 2023 10:03:36 +0200
Subject: [PATCH] Bug 33105: Redirect to 404 if no vendor exists

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 acqui/vendor_issues.pl                                       | 5 +++++
 .../intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt     | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/acqui/vendor_issues.pl b/acqui/vendor_issues.pl
index 561769c28e..48a8ef703e 100755
--- a/acqui/vendor_issues.pl
+++ b/acqui/vendor_issues.pl
@@ -48,6 +48,11 @@ if ( $issue_id ) {
 }
 my $vendor = Koha::Acquisition::Booksellers->find($booksellerid);
 
+unless ( $vendor ) {
+    print $input->redirect("/cgi-bin/koha/errors/404.pl");
+    exit;
+}
+
 if ( $op eq 'add_form' || $op eq 'show' ) {
     $template->param( issue => $issue );
 } elsif ( $op eq 'add_validate' ) {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt
index 4a6a672875..0a9de738a7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt
@@ -137,7 +137,8 @@
             <input type="hidden" name="issue_id" value="[% issue.issue_id | html %]" />
             <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete</button>
         </form>
-        <form action="/cgi-bin/koha/acqui/vendor_issues.pl?booksellerid=[% vendor.id | uri %]" method="get">
+        <form action="/cgi-bin/koha/acqui/vendor_issues.pl" method="get">
+            <input type="hidden" name="booksellerid" value="[% vendor.id | html %]" />
             <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
         </form>
     </div>
-- 
2.39.5