]> git.koha-community.org Git - koha.git/commit
Bug 29771: Scalar context for split
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 23 Dec 2021 19:58:57 +0000 (16:58 -0300)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 25 Apr 2022 19:50:15 +0000 (19:50 +0000)
commitbac05d3f3710c5aa09e0053055c1802ddef16e36
treefbaf51c21769f469e26898303c28a786b5b2a24f
parent72a477c43f2ea8936a9fc977033494eef87e7a88
Bug 29771: Scalar context for split

This patch tackles a very specific scenario. Calling split(...,
CGI::param) makes it be called in list context. The split docs say:

split /PATTERN/,EXPR,LIMIT

this means the first CGI param will be used as EXPR and the second one
as LIMIT, which is wrong anyway. So the fix is to just force scalar
context.

To test:
1. Not sure, just make sure nothing breaks when using the scripts in the
   browser.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit e5dc760b92bd939245c3d24a0cfa3db99f9ac764)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
circ/article-request-slip.pl
tools/batch_delete_records.pl
tools/batch_record_modification.pl
tools/inventory.pl