]> git.koha-community.org Git - koha.git/commit
Bug 20783: Use iframe to embed Youtube videos
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 12 May 2020 10:54:50 +0000 (12:54 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Wed, 17 Jun 2020 22:37:45 +0000 (22:37 +0000)
commit61e66110685b0fe611886b4709ac25850690b22d
tree52d29706c847a369cdba3629fac0125e8f381493
parent9893fb4ec5a480b7adcbb27f321f7387a4f38f45
Bug 20783: Use iframe to embed Youtube videos

WWW::YouTube::Download is broken and not reliable.
Other alternative was to use HTML::Video::Embed but not updated since
years.

The best alternative seems to follow youtube advise and use an iframe
https://developers.google.com/youtube/iframe_api_reference

Test plan:
Put youtube video in 856$u (using different url formats, youtu.be,
youtube.com/embed, etc.)
Enable HTML5MediaEnabled and HTML5MediaYouTube and confirm that the
youtube videos are correctly embeded.

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 2d7e08bc0e8c1ab6f21cce06932bb7dd6660cfcd)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/HTML5Media.pm
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt