Allow param "bornum" as in template, not just "borrowernumber". Added FIXMEs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Partial fixes to enable unapi for non-zebra and non-public-facing sru

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 2004: changes to guided reports on items

* Added items.location and items.ccode to list of
  columns available for limiting
* choice of item type column (i.e., biblioitems.itemtype
  or items.itype) to limit by now respects
  item-level_itypes syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1980: changes to label-item-search.pl to allow pagination over large result sets

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug 1980: some cleanup, getting ready to add pagination to label-item-search.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Dates.pm - trivial perldoc corrections

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

NOTE: REQUIRES INSTALLATION OF Image::Magick; Adding image scaling/resizing capability to picture-upload.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Quell 7 warnings: "my" variable $irule masks earlier declaration in same scope.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding max-width to patron image in sidebar, correcting some markup in picture uploads.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding COinS support to cart pop-up; Hide similar items in opac-details if no similar items are found.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixes for tablesorter problems when there are no checkouts from today; Other markup corrections.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some minor markup corrections, style fixes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tweaking display of resident search form; Tweaking labels breakcrumbs; Formatting tools menu.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Completing table sort js integration for checkouts and holds.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some formatting changes, bringing displays in circ and moremember more in line with each other

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix calls to CalcFine, and make fines obey CircControl syspref (get homebranch withssue data).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding MARC21 record descriptions as per loc.gov//marc/bibliographic/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding additional statuses display for XSL

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding Library of Congress Classification to display

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing escape=url as it broke '=' for q=query

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding famfamfam iconset, improving isbn for amazon content, etc.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Cleaning up XSL to display a few additional MARC21 fields

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting screen help for patron image upload from moremember.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add a working fines script, some changes to CalcFine and Circulation.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Show enumchron, copynumber in opac detail iff present.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add Logging module 'SYSTEMPREFERENCE', log adds, mods & deletes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix authorised_value '0' problem with last commit on detail.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More cleanup of location & ccode authval handling.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Remove hardcoded LOC AND CCODE authvals; fix no display of location on staff details page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding Ç as equivale nt to c for frenchies

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

some fixes to unimarc authorities ordering

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUGFIX : using " instead of ' to avoid javascript failure

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUGFIX renewal

otherwise, the new issuedate will be empty

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

The link field is now a CCL index, so it must be longer than 5 char long

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some missing sysprefs in french

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug Fixing : Editing items was broken when using diacritics.

Encoding was wrong

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

a reminder about tags for the RM

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

don't show famfamfam for a language

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More work on label printing tool

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing a stray warn

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Commenting out Dumper

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some coding improvement and misc changes to BIBBAR labels

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some markup corrections, breadcrumb improvement, and other minor changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting table-sorter js for different table structures (Amazon content on or off, item-level-itemtypes on or off)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to allow librarian to turn off item-level holds in the OPAC. Requires the addition of OPACItemHolds system pref ("Allow OPAC users to place hold on specific items. If OFF, users can only request next available copy." Type: YesNo). Also modifying redirect to show Holds tab in opac-user.pl.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add backtrace printing option through SetEnv KOHA_BACKTRACES 1

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more XHTML corrections for new circ reports

Note: I question the use of GROUP_CONCAT(... SEPARATOR '<br/>'),
because that puts knowledge of the output mechanism (currently HTML)
into the SQL query.  However, I am not fixing this right now.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

SQL cleanup in new circ scripts: use placeholders

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

use C4::Debug instead of checking DEBUG env var directly

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed typo in template

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

XHTML fixes for various circ templates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

change references to 'reserves' in billing report template

New billing report has nothing to do with hold requests per se,
so change template variables in order to not confuse customizers.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

various date-related cleanups in circ

* use Date::Calc to perform date arithmetic
* use Date::Calc::Today to consistently format the current date
* format date per syspref in overdue report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

disallow division by zero in hold ratio report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

another "Reserves" => "Hold" in template

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

minor circ template cleanup

[1] did some "Reserve" => "Hold" to keep language consistent
[2] Moved hold ratios report and billing report on circ
    home page to group with related reports

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

All patches to Koha 3 beta to date. All work with branches.

 Billing.pl     -- new, gives bills that occur in a range, works
 pendingreserves.pl  -- fixed, works now, with branches also
 reserveratios.pl  -- indicates distressed reserves
 itemslost.pl  -- Fix to this to make it more useful and fix bugs
 Itmes.pm -- small change to work for itemslost, should not affect
             anything else
 and all tmpl files.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding PATCRD print type

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed locating OPAC stylesheet in a "standard" install

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed MODS biblio export on a "standard" install

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1986: fix card view in Z39.50 search results

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed memory leak I introduced

Accidentally introducing a circular reference in a
MARC::Record object does not lead to goodness, particularly
if you export lots and lots of them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

work around issue in MARC::Charset

Because of a bug in MARC::Charset 0.98, if a string to convert from
MARC-8 to UTF-8 has (a) one or more diacritics that (b) are only in character positions
128 to 255 inclusive, the resulting converted string is not in
UTF-8, but the legacy 8-bit encoding (e.g., ISO-8859-1).  As a result,
when such a record is converted to XML using ->as_xml_record(), the resulting
XML can be truncated at the offending character.  An example of such a record
is one that has a price in Briish pounds in the 260$c but no other diacritics.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding a couple of missing YUI js files; Adding comment preview to comments system (needs review).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Improving comments style and markup, adding highlighting for comments made by logged-in user.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting a small case-sensitive bug.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

for DebugLevel=2; improved reporting of version numbers

Koha software and DB version numbers now reported;
also improved formatting of multi-line error messages.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improved formatting of fatal error messages sent to browser

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed invocation of CGI::Carp::set_message

The message handler in C4::Context is now correctly
passed CGI::Carp.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1890: fixing calls to C4::Search::SimpleSearch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug 1980: adding parameters to C4::Search::SimpleSearch to allow limiting the number of results returned.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding file size limit to picture-upload.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixes to make all label/patron card templates uniform

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding sample label form for Patron Cards

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Catalogue => Search in staff home page

Changed to match similar change in the menu
bar.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

avoid croak on latest CVS version of MARC::Record

The semantics of MARC::Record->delete_field() changed
slightly in the latest CVS version of MARC::Record.
delete_field() will now croak if passed an undef
scalar, while the version of MARC::Record from CPAN
accepts that input.  Since some packages of MARC::Record
in the wild appear to be based on the CVS version, not
the CPAN version, added a check where needed to avoid
the croak.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More work on patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding member search to patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Work on adding patron search to patron card generation feature.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tweaking the interface of OPAC shelves to more closely match the pattern set by the staff client. Simplifies and focuses on specific tasks.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Notifying the user when they have selected no items and clicked 'Add to list.'

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Visual tweaks for login screen.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correction to prevent js error when table has no data.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Change LateOrders to inclusive <=, s/supplier/vendor , s/parcel/shipment.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

still more rebuild_zebra refactoring

Merged duplicate code for indexing bibs and
authorities into a single index_records() function.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

IMPORTANT: added -z option to rebuild_zebra.pl

The -z option, when used in conjunction with -a and/or -b,
selects the records to reindex from the zebraqueue table.
Both record updates and record deletes are handled.

-z is cannot be used with -s or -r: the updated records
must always be freshly exported, and if zebraqueue
is to be processed, it's assumed that you don't want
to drop the Zebra index first.

This means that rebuild_zebra.pl -b -a -x can be
used as a cronjob to update the indexes periodically; it
is believed that this will offer much better indexing
performance on some setups as compared to zebraqueue_daemon.pl,
which uses Z39.50 extended services to send record updates
to Zebra.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

rebuild_zebra: exit if both -a and -x specified

At moment using both -a (index authorities) and
-x (export records as MARC XML) is not allowed -
if the Zebra authority database is using the DOM
filter, zebraidx will not be able to process the
exported records correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more rebuild_zebra.pl refactoring

1. Logic to fix up record IDs, UNIMARC 100 field,
   and record leader now in separate functions.
2. Removed (incorrect) logic to save corrected record
   in database.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

refactor rebuild_zebra: new routine for invoking zebraidx

Created a routine for calling zebraidx, replacing
separate invocations for bibs and authorities.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

rebuild_zebra.pl: removed disused $limit option

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Markup corrections. Tweaking holds interface.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding function to empty cart when user logs out.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Markup correction.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing a couple of unused templates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing old patronimages js check, adding missing patron image variable to script.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Reformatting holds list to better match checkouts list

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing bug that caused all items in checked-out list to show up as overdue; Reformatting table and tweaking select all/none behavior.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing bug where language menu footer wouldn't "stick."

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Beginning work on Calendar compatibility fixes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>