From 043ccc71632e3c6fcdff41fe5eafa01e26e8a36f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Sat, 21 May 2022 19:23:32 +0000 Subject: [PATCH] Bug 30828: Remove useless 'type' parameter in placerequest.pl To test: 1) Grep for placerequest.pl in the source code and check that request.tt is the only place where the type parameter is passed. Signed-off-by: David Nind JD amended patch: adjust commit title Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 54a6c73c6d6e94554b7e4c15554e08d79e3eb578) (cherry picked from commit 88f257ba55e4f0a4c58c0f64815b9995b7072080) Signed-off-by: Arthur Suzuki --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 -- reserve/placerequest.pl | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index b450007989..4ac89633ab 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -450,8 +450,6 @@
- - [% IF ( multi_hold ) %] diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl index 5f320fdb89..22a4d96801 100755 --- a/reserve/placerequest.pl +++ b/reserve/placerequest.pl @@ -43,7 +43,6 @@ my $notes = $input->param('notes'); my $branch = $input->param('pickup'); my $startdate = $input->param('reserve_date') || ''; my @rank = $input->multi_param('rank-request'); -my $type = $input->param('type'); my $title = $input->param('title'); my $checkitem = $input->param('checkitem'); my $expirationdate = $input->param('expiration_date'); @@ -70,7 +69,7 @@ foreach my $bibnum (@biblionumbers) { my $found; -if ( $type eq 'str8' && $borrower ) { +if ( $borrower ) { foreach my $biblionumber ( keys %bibinfos ) { my $count = @bibitems; -- 2.39.5