]> git.koha-community.org Git - koha.git/commit
Bug 31214: Make subfield code non-editable in MARC framework editor
authorJoonas Kylmälä <joonas.kylmala@iki.fi>
Sun, 7 Aug 2022 11:24:12 +0000 (11:24 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 9 Aug 2022 10:40:47 +0000 (07:40 -0300)
commit045ead15fd477b54d1193bcd7fbcc2df1984a145
tree05a6ff321f9a2a84ed97418aad2f58dcd0df5b6c
parent2395f781fde622e5b9219a2a1b2e2f4d0904450e
Bug 31214: Make subfield code non-editable in MARC framework editor

The subfield code field became editable in framework
editor due to a regression that happened during the
switch from a previous template framework koha used
to the new Template toolkit framework currently in use:
Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768)
The regression happened due to the template syntax
not being updated to the new one in this particular
case.

Note: The subfield code field doesn't align with the
      other fields anymore after this patch. However,
      this alignment issue is in every other Koha form
      in intranet and should be fixed in the global
      CSS rules.

1) Apply patch
2) Browse to
   /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR
3) Notice the subfield code is non-editable
4) Notice the subfield code is still editable in the New tab.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt