]> git.koha-community.org Git - koha.git/commit
Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary
authorOwen Leonard <oleonard@myacpl.org>
Fri, 16 Jun 2023 12:47:29 +0000 (12:47 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 9 Oct 2023 14:41:15 +0000 (11:41 -0300)
commit04648e58195a6c9e933f49e1ac666327ac7adfed
treeb331315247c5327c08a624821606b8ef32e43c9c
parentb25cd57592a24db7289ce5283f9170b31e00bec2
Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary

This patch removes some string variable definitions from
opac-bottom.inc. The strings can now be picked up for translation from
the corresponding <script> block.

To test you must enable OpenLibrarySearch and enter OverDrive
credentials to enable OverDrive search integration.

- Perform a search in the OPAC.
- As the results page loads you should see at the top "Searching
  OverDrive..." and "Searching OpenLibrary..."
- When the searches complete you should see "Found X results in the
  library's Y collection" for each service.
- Try to trigger an error message by entering the wrong (non-zero) value
  for the OverDriveLibraryID preference.
- The search results page should show "Error searching OverDrive
  collection"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt