]> git.koha-community.org Git - koha.git/commit
Bug 10480: Remove useless routines and irrelevant pod lines
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 11 Dec 2014 10:35:57 +0000 (11:35 +0100)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 16 Apr 2015 17:48:40 +0000 (14:48 -0300)
commit0d177c9546ca697b49c73ea60fb7171ab220b279
tree99d755feb9bd3e1f10b7d3774d7a364f7bb20553
parent331cbeb1df86ed92843ac80b74952a085be556bc
Bug 10480: Remove useless routines and irrelevant pod lines

This patch makes the following cleanup actions for all plugins:

1- Remove sub plugin_parameters. This function is not used.
2- Remove empty plugin or empty plugin_javascript subs.
3- Remove empty Blur, Clic or Focus routines from javascript.
4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs.
5- Remove the last 1; line. It is no longer needed.

Test plan:
Run the unit test t/db_dependent/FrameworkPlugins.t
Test some cataloguing plugins in addbiblio.
Test some item plugins in additem and neworderempty.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I also checked the syntax of all plugins with perl -c.
And checked the pod (if any) with podchecker: Two files still produce a
warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
77 files changed:
cataloguing/value_builder/barcode.pl
cataloguing/value_builder/barcode_manual.pl
cataloguing/value_builder/callnumber-KU.pl
cataloguing/value_builder/callnumber.pl
cataloguing/value_builder/dateaccessioned.pl
cataloguing/value_builder/macles.pl
cataloguing/value_builder/marc21_field_003.pl
cataloguing/value_builder/marc21_field_005.pl
cataloguing/value_builder/marc21_field_006.pl
cataloguing/value_builder/marc21_field_007.pl
cataloguing/value_builder/marc21_field_008.pl
cataloguing/value_builder/marc21_field_008_authorities.pl
cataloguing/value_builder/marc21_field_040c.pl
cataloguing/value_builder/marc21_field_040d.pl
cataloguing/value_builder/marc21_field_245h.pl
cataloguing/value_builder/marc21_leader.pl
cataloguing/value_builder/marc21_leader_authorities.pl
cataloguing/value_builder/marc21_leader_book.pl
cataloguing/value_builder/marc21_leader_computerfile.pl
cataloguing/value_builder/marc21_leader_video.pl
cataloguing/value_builder/marc21_linking_section.pl
cataloguing/value_builder/normarc_field_007.pl
cataloguing/value_builder/normarc_field_008.pl
cataloguing/value_builder/normarc_leader.pl
cataloguing/value_builder/stocknumber.pl
cataloguing/value_builder/stocknumberAV.pl
cataloguing/value_builder/stocknumberam123.pl
cataloguing/value_builder/unimarc_field_010.pl
cataloguing/value_builder/unimarc_field_100.pl
cataloguing/value_builder/unimarc_field_100_authorities.pl
cataloguing/value_builder/unimarc_field_105.pl
cataloguing/value_builder/unimarc_field_106.pl
cataloguing/value_builder/unimarc_field_110.pl
cataloguing/value_builder/unimarc_field_115a.pl
cataloguing/value_builder/unimarc_field_115b.pl
cataloguing/value_builder/unimarc_field_116.pl
cataloguing/value_builder/unimarc_field_117.pl
cataloguing/value_builder/unimarc_field_120.pl
cataloguing/value_builder/unimarc_field_121a.pl
cataloguing/value_builder/unimarc_field_121b.pl
cataloguing/value_builder/unimarc_field_122.pl
cataloguing/value_builder/unimarc_field_123a.pl
cataloguing/value_builder/unimarc_field_123d.pl
cataloguing/value_builder/unimarc_field_123e.pl
cataloguing/value_builder/unimarc_field_123f.pl
cataloguing/value_builder/unimarc_field_123g.pl
cataloguing/value_builder/unimarc_field_123i.pl
cataloguing/value_builder/unimarc_field_123j.pl
cataloguing/value_builder/unimarc_field_124.pl
cataloguing/value_builder/unimarc_field_124a.pl
cataloguing/value_builder/unimarc_field_124b.pl
cataloguing/value_builder/unimarc_field_124c.pl
cataloguing/value_builder/unimarc_field_124d.pl
cataloguing/value_builder/unimarc_field_124e.pl
cataloguing/value_builder/unimarc_field_124f.pl
cataloguing/value_builder/unimarc_field_124g.pl
cataloguing/value_builder/unimarc_field_125.pl
cataloguing/value_builder/unimarc_field_125a.pl
cataloguing/value_builder/unimarc_field_125b.pl
cataloguing/value_builder/unimarc_field_126.pl
cataloguing/value_builder/unimarc_field_126a.pl
cataloguing/value_builder/unimarc_field_126b.pl
cataloguing/value_builder/unimarc_field_127.pl
cataloguing/value_builder/unimarc_field_128a.pl
cataloguing/value_builder/unimarc_field_128b.pl
cataloguing/value_builder/unimarc_field_128c.pl
cataloguing/value_builder/unimarc_field_130.pl
cataloguing/value_builder/unimarc_field_135a.pl
cataloguing/value_builder/unimarc_field_140.pl
cataloguing/value_builder/unimarc_field_141.pl
cataloguing/value_builder/unimarc_field_210c.pl
cataloguing/value_builder/unimarc_field_210c_bis.pl
cataloguing/value_builder/unimarc_field_225a.pl
cataloguing/value_builder/unimarc_field_4XX.pl
cataloguing/value_builder/unimarc_field_686a.pl
cataloguing/value_builder/unimarc_field_700-4.pl
cataloguing/value_builder/unimarc_leader.pl