]> git.koha-community.org Git - koha.git/commit
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 4 Dec 2017 18:39:48 +0000 (15:39 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 7 Dec 2017 13:09:50 +0000 (10:09 -0300)
commit0d828094e8e12a5c8ee814044a46bafb9897a552
treef4b98d23b6c24a88f1eb60f90c4091e4a9d36ec2
parentf03da2810cf9fa0f671243f90d31a915c67d6825
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Bug 17898 tries to help users identify reports affected by the move of marcxml to the biblio_metadata table, however, the auth_header table still uses the column name 'marcxml' and so reports as needing updated though it doesn't.

C4::Reports::Guided::convert_sql only converts if the sql query contain biblioitems and marcxml.
We should use the same regexp in the controler script.

Test plan:
Use a sql report that use auth_header.marcxml (see https://wiki.koha-community.org/wiki/SQL_Reports_Library)
After the this the report should not be longer marked as obsolete on the report list view

Replicated bug with the following SQL:
select marcxml from auth_header;

Patch applied correctly and functioned as expected.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
reports/guided_reports.pl