]> git.koha-community.org Git - koha.git/commit
Bug 22253: Check we actually need to update the password
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 31 Jan 2019 19:30:25 +0000 (16:30 -0300)
committerroot <root@665746303f3b>
Mon, 4 Feb 2019 13:44:29 +0000 (13:44 +0000)
commit0f83ac98c753efbae7e33619be717327a820f2e1
treed794955b931fc981b8bba2d81405a49a8294f24e
parent766eaa0df45f04523737a8f04b045122b3e11b18
Bug 22253: Check we actually need to update the password

This patch makes memberentry.pl check if password needs to be updated
before attempting to call set_password. Above this there's a check that
won't raise any errors if no password is passed, or the default string (****) is received.

So we could reach that line of code with no password, but the code
wouldn't check that.

To test:
- In master, edit any patron without changing the password
=> FAIL: It raises an exception
- Apply this patch
- Edit the patron withtout changing the password
=> SUCCESS: Edit successful
- Edit the patron, changing the password
- Try to login with the new password
=> SUCCESS: The password got changed correctly
- Sigh off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
members/memberentry.pl