]> git.koha-community.org Git - koha.git/commit
Bug 12748 - Fixes duplicate serials with an "expected" status bug
authorremi <remi.mayrand-provencher@inLibro.com>
Tue, 11 Aug 2015 15:10:45 +0000 (11:10 -0400)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 17 Jun 2016 14:25:18 +0000 (14:25 +0000)
commit10fd9f5ec0d5faa7b54b0bfaf5a7b8fccd665f0a
tree09911a3a2dde02f0b9ea99024b381fd32f7bc58e
parent42cd9ca1447f4d576d9f1ad51e275e70c8bf9249
Bug 12748 - Fixes duplicate serials with an "expected" status bug

Added a new sub to Serials.pm to be able to get serials with their statuses.
Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything.

Also modified Serials.t to be able to test those changes.

Test Plan
1) Apply patch
2) Run ./t/db_dependent/Serials.t
3) Validate that there are no errors
4) Go on "Serial collection information" page for a serial of your choice
5) Click on "Generate next"
6) Change the status of the original serial from "late" to "expected"
7) Change the newly generated serial from "expected" to "delete"
8) Validate that there are no new serials created by instruction 7 and that the serial was deleted
9) Run ./t/db_dependent/Serials.t

With QA Fixes

- Use the constant instead of the code (1 vs EXPECTED)
- Avoid interpolation in query
- use selectall_arrayref instead of fetchall_arrayref

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Serials.pm
t/db_dependent/Serials.t [changed mode: 0644->0755]