]> git.koha-community.org Git - koha.git/commit
Bug 22862: Normalize SMS messaging numbers before validating them
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 7 May 2019 18:53:29 +0000 (14:53 -0400)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 24 Jun 2019 14:01:36 +0000 (15:01 +0100)
commit115f4f2045a6c695d1eed47cd401b7759630ac4d
tree06d01aaa08123981323b85e3585d9cadd9ec5c11
parentcc9d167af6081009bd3c41c7dd91f90c76c6ca1b
Bug 22862: Normalize SMS messaging numbers before validating them

Librarians often copy and paste patron data, including phone numbers. SMS phone numbers are now being validated to conform to the E.164 specification. It would be nice to try to normalize that data by stripping non-numeric data from the paste (i.e. dashes, parens, etc ).

Test Plan:
1) Apply this patch
2) On the staff side, Attempt to enter invalid characters the SMS number field
3) Note you cannot enter invalid characters
4) Attempt to paste a phone number with invalid characters
5) Note those characters are removed on paste
6) Repeat these steps on the OPAC

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/js/members.js
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt