]> git.koha-community.org Git - koha.git/commit
Bug 23310: Reduce noise in Koha::Biblio
authorMark Tompsett <mtompset@hotmail.com>
Fri, 12 Jul 2019 01:30:47 +0000 (01:30 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 28 Oct 2019 12:38:39 +0000 (12:38 +0000)
commit11c9fe380577e3e06aafefa25aad490975aaebeb
tree1b006d66f952e8a702fe4d2376066d92a83d16a7
parent618d8a690ee73327bd11ca30680be3f93132d74d
Bug 23310: Reduce noise in Koha::Biblio

The use of uninitialized value flooding plack-error
can get rather distracting and annoying.
By using "// q{}" after each of the subfield() calls
this eliminates the problem

TEST PLAN
---------
vertical break where you stop your cut-and-paste.
This test should be repeatable with cut-and-paste
easily.

restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
-- may strangely be quiet.

prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Biblio.t
-- should be noisy.

prove t/db_dependent/Koha/Biblio.t
-- will always be noisy now.

exit
git bz apply 23310

restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
-- will be quiet.

prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Biblio.t
-- will be quiet.

prove t/db_dependent/Koha/Biblio.t
-- will be quiet.

qa -v 2 -c 1

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/Biblio.pm