Bug 36420: Allow Basic authentication using `cardnumber`
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 27 Mar 2024 12:01:32 +0000 (12:01 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Thu, 18 Apr 2024 14:51:14 +0000 (16:51 +0200)
commit154a2ea9ad5b6e911a504b8798f5ffe6df1c2297
treeddfe5a2ff1c04bbb7217872c401beafc717f67fe
parent5c3ad38157f483aeb4ff26048a838b3ba6ad34fc
Bug 36420: Allow Basic authentication using `cardnumber`

This patch makes the API Basic authentication work with cardnumbers.
The used `checkpw_internal` method already does the fallback check.

To test:
1. Apply the unit tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/auth_basic.t
=> FAIL: Tests explode! [1]
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

[1] This highlights an underlying bug! Instead of getting 403, etc we get a 500. This is because of the internal fallback mechanism allowing the cardnumber+password combination, but then the Koha::Patron->find... not finding :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Koha/REST/V1/Auth.pm