]> git.koha-community.org Git - koha.git/commit
Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 18 May 2021 08:43:05 +0000 (10:43 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 18 May 2021 08:43:05 +0000 (10:43 +0200)
commit21d8298c7708281a9ab87851ea55f75559e57cf4
treef63bb46f9ffa225dcc0d390808b171930541a2af
parentd5c155203e803ff94ab87e51ab753d919d493dc7
Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm

C4/Auth_with_shibboleth.pm has:
  if ( any { /(^psgi\.|^plack\.)/i } keys %ENV )
When others have:
  if ( any { /(^psgi\.|^plack\.)/i } keys %ENV )

This has been highlighted by https://gitlab.com/koha-community/koha-testing-docker/-/issues/249 that introduces a PLACK_WORKERS env vars, and t/Auth_with_shibboleth.t was failing with

 #   Failed test 'checkpw_shib tests'
 #   at t/Auth_with_shibboleth.t line 335.
 Invalid parameter passed, categorycode= does not exist# Looks like your test exited with 255 just after 5.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Auth_with_shibboleth.pm