]> git.koha-community.org Git - koha.git/commit
Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices
authorAleisha Amohia <aleishaamohia@hotmail.com>
Wed, 15 Feb 2023 02:15:15 +0000 (15:15 +1300)
committerJacob O'Mara <jacob.omara@ptfs-europe.com>
Wed, 1 Mar 2023 15:33:26 +0000 (15:33 +0000)
commit2390d252b9dd4bc996083ac3df61e2a6949c3026
tree9d0f89abb4e983f62b02979fb81b3b93495baaf8
parent7fb699f46d3dc07cb7958a2a18b2598f0902fb7a
Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices

This patch fixes two recalls notices which are referencing old column
names, so they leave empty fields when the notices are generated.

To test:

1) Apply database updates and restart services
2) Go to Tools -> Notices
3) Find the RECALL_REQUESTER_DET notice, open the Print tab
4) Confirm there are no references to recalls.waitingdate or
recalls.recallnotes. Confirm the reference is fixed to
recalls.waiting_date and recalls.notes
5) Find the PICKUP_RECALLED_ITEM notice, open the Email tab
6) Confirm there are no references to recalls.branchcode or
recalls.expirationdate. Confirm the reference is fixed to
recalls.pickup_library_id and recalls.expiration_date

Sponsored-by: Catalyst IT
https://bugs.koha-community.org/show_bug.cgi?id=32697
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit f7e05c32633d30da88d590a7ad405ebe97b46443)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
installer/data/mysql/atomicupdate/bug_32967_-_fix_recalls_notices.pl [new file with mode: 0755]
installer/data/mysql/en/mandatory/sample_notices.yml