]> git.koha-community.org Git - koha.git/commit
Bug 19178: Remove outdated sms/* scripts and related files
authorKatrin Fischer <katrin.fischer.83@web.de>
Sat, 26 Aug 2017 15:09:41 +0000 (15:09 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 27 Oct 2017 17:10:29 +0000 (14:10 -0300)
commit377c9f15896e2ee4515f8b31a6424d5ec9d89f17
tree218ad038e868e0a63267eb812eb2bcd5dc2ef201
parent6835760dcfa60abec027af3ff0cfafca8aea6f14
Bug 19178: Remove outdated sms/* scripts and related files

Those files appear unmaintained and unusable with current
Koha and should be removed.

It appears at some point there was work done on a feature
to send SMS messages to a phone number using a form in
the tools area.
This has never been documented, files and git history
make it look like work remained unfinished.

sms/sms_listen_windows_start.pl
- targetted for Windows, which is not supported by Koha

00-strict.t
- reference to sms removed

sms/sms_listen.pl
- refers to a table sms_messages that doesn't exist
- uses getmember() that doesn't exist

sms/sms.pl
- script calls routines that no longer exist in SMS.pm
  error_codes(), parse_phone(), write_sms()
- template sms-home.tt is not accessible form anywhere
  in the templates

sms-home.tt
- see sms/sms.pl

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Makes sense. 00-strict.t runs OK after applying the patch.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/sms/sms-home.tt [deleted file]
sms/sms.pl [deleted file]
sms/sms_listen.pl [deleted file]
sms/sms_listen_windows_start.pl [deleted file]
t/db_dependent/00-strict.t