]> git.koha-community.org Git - koha.git/commit
Bug 18725: (QA follow-up) Use make_column_dirty instead of status change
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 13 Apr 2018 07:38:50 +0000 (09:38 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 16 Apr 2018 16:07:22 +0000 (13:07 -0300)
commit38132cabbb88a51b3b457972dc7119eecdc9cfb5
treebcb35b583aae31ef39276ed30e206b82e6430197
parent8ad45474324b672fb48d8b7af83a94184cd1b2f9
Bug 18725: (QA follow-up) Use make_column_dirty instead of status change

Moving the status to the invalid 'processing' might well have unwanted
side-effects. (The status column will be set to empty string and we have
a problem if it is not processed.)

This patch allows pass-through of DBIX's make_column_dirty in
Koha::Object (simple tests included) and uses it to force an update.
If the update does not return true, it still exits.

Test plan:
[1] Read the changes.
[2] Run t/db_dependent/Koha/Object.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Letters.pm
Koha/Object.pm
t/db_dependent/Koha/Object.t