]> git.koha-community.org Git - koha.git/commit
Bug 23463: (follow-up) Fix timestamp default value
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 28 Jan 2020 11:54:37 +0000 (12:54 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 23 Mar 2020 09:26:33 +0000 (09:26 +0000)
commit57eb6e42265a830aabb01f5de0bcab49bd090356
treef68888b4d45e1b37e1b362d1517e337df996455d
parent794e8f992eee39641ec83beb83c140c6f7df4814
Bug 23463: (follow-up) Fix timestamp default value

For discussion, this patch revert the changes made previously.

This line exists in Koha::Item->store as it is the translation of:
    if (exists $item->{'timestamp'}) {
        delete $item->{'timestamp'};
    }
that was coming from _do_column_fixes_for_mod (called from ModItem)

To preserve existing behavior I would be in favor of keeping it like that to
avoid regression, and deal with it separately if we want to improve/remove it.

So basically here we are setting it to undef in Koha::Item->store to make it
handle correctly by the parent Koha::Object->store. I agree that's kind of weird
and must be improved.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/Item.pm
Koha/Object.pm