]> git.koha-community.org Git - koha.git/commit
Bug 21089: Overlapping elements in ordering information on acqui/supplier.pl
authorOwen Leonard <oleonard@myacpl.org>
Mon, 7 Jan 2019 13:48:55 +0000 (13:48 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 28 Jan 2019 11:37:09 +0000 (11:37 +0000)
commit5c547ffff2ca04a87695a57e972171cd76cc828c
tree1f01fdf0586ed3b44cf69a208ce8aa976fc42798
parent1d5934cae52dd96d9c5b8685a5f5531c69e92df8
Bug 21089: Overlapping elements in ordering information on acqui/supplier.pl

This patch changes the HTML structure of the vendor edit page so that
the markup is a little simpler. CSS is modified to match. This structure
should serve as a model for other similar form structures:

 <fieldset class="rows">
     <ol>
         <li>
             <label>General label:</label>
             <label class="radio">
                 Specific label 1 <input type="radio" />
             </label>
             <label class="radio">
                 Specific label 2 <input type="radio" />
             </label>
         </li>
     </ol>
 </fieldset>

To test, apply the patch and regenerate the staff client CSS.

 - Go to Acquisitions -> Vendor search -> Vendor -> Edit vendor
 - In the "Ordering information" section, confirm that the position of
   radio buttons looks correct.
 - Confirm that radio button labels work correctly.
 - Confirm that the adjacent dropdown menus work well.

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt