]> git.koha-community.org Git - koha.git/commit
Bug 24594: Rewrite authorities_normal_marc21 to YAML
authorBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Wed, 5 Feb 2020 14:55:45 +0000 (11:55 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 9 Mar 2020 13:54:45 +0000 (13:54 +0000)
commit5ead9529da75ca5fdd26e7411c5b3ee3487d0e1c
treefd3be91828f6aa327c7e4801d0f6e62528a56a9b
parentd9b83c12c601ae43bcf67125e351c098b4fe1efa
Bug 24594: Rewrite authorities_normal_marc21 to YAML

YAML version of marc21 mandatory authorities_normal_marc21.

To test:
1) Do a clean install with mandatory data,
   dump table auth_types, auth_tag_structure and
   auth_subfield_structure, reserve.

2) Apply this patch and it's dependencies

3) Do a clean install, dump again and compare
   No major differences expected

4) Try translation
  a) Go to misc/translator
  b) create files for a new language
     ./translate create xx-YY
  c) Check new file po/xx-YY-instaler-MARC21.po
     Verify strings from this file.
  d) Install new language
     ./translate install xx-YY
  e) Try clean install with new files

NOTE: This patch fails with qa tools!
Reason is that qa tools use YAML.pm module to
check files, but Installer.pm or LangInstaller.pm
are using YAML::Syck, using that module gives
no error, check for example:

perl -e 'use YAML::Syck qw( LoadFile ); $y = LoadFile("authorities_normal_marc21.yml");'
No error!

perl -e 'use YAML qw( LoadFile ); $y = LoadFile("authorities_normal_marc21.yml");'
Error!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql [deleted file]
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.txt [deleted file]
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.yml [new file with mode: 0644]