]> git.koha-community.org Git - koha.git/commit
Bug 10131: Add a fallback if the pref search is not a valid regex
authorJonathan Druart <jonathan.druart@biblibre.com>
Tue, 14 Apr 2015 11:45:14 +0000 (13:45 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 21 Apr 2015 12:30:34 +0000 (09:30 -0300)
commit65cb0f5be636a15387a3996c32da051d4114719e
tree73ee65c27c474fa7be8eaa139213fc0aa27a4c0d
parent62ec79a4fdf20c9d351baffced64152d70420cd7
Bug 10131: Add a fallback if the pref search is not a valid regex

It's possible to search prefs using a regex.
But it the regex is not correctly written, the app explodes.
We should provide a fallback.

Test plan:
0/ Does not apply the patch
1/ Search for sysprefs with "notes.*", note the number of results
2/ Search for *notes*, boom
3/ Apply the patch
4/ Repeat 1 and confirm you get the same number of results
5/ Repeat 2 and confirm you don't get the error anymore

NOTE: As noted on comment #4, the kaboom is because of the
      leading * and not the following *, because 's*' is a valid
      regular expression, while '*n' is not.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
admin/preferences.pl