]> git.koha-community.org Git - koha.git/commit
Bug 6984 - Holds statistics doesn't work.
authorGarry Collum <gcollum@gmail.com>
Wed, 1 Feb 2012 15:15:46 +0000 (10:15 -0500)
committerPaul Poulain <paul.poulain@biblibre.com>
Fri, 3 Feb 2012 13:14:15 +0000 (14:14 +0100)
commit67825637beb8ce3fabb7f34548f6962dec2993e5
tree258b87526ecfa28b03ee01e3cd776077b62bd5fd
parent1034b21dea0460b58ef63550cf920b17d5e2662e
Bug 6984 - Holds statistics doesn't work.

This patch fixes several errors in reserves_stats.pl and reserves_stats.tt.

Testing -
To test this patch, data must be in either the reserves table or old_reserves or both.  The following SQL will give you the raw data that is used by the report.

SELECT priority, found, reservedate, notificationdate, reminderdate,
waitingdate, cancellationdate, borrowers.categorycode, items.itype,
reserves.branchcode, holdingbranch, items.homebranch, items.ccode,
items.location, items.itemcallnumber, borrowers.sort1, borrowers.sort2
FROM reserves
LEFT JOIN borrowers on (borrowers.borrowernumber = reserves.borrowernumber)
LEFT JOIN items on (items.itemnumber = reserves.itemnumber)
UNION SELECT priority, found, reservedate, notificationdate, reminderdate,
waitingdate, cancellationdate, borrowers.categorycode, items.itype,
old_reserves.branchcode, holdingbranch, items.homebranch, items.ccode,
items.location, items.itemcallnumber, borrowers.sort1, borrowers.sort2
FROM old_reserves
LEFT JOIN borrowers on (borrowers.borrowernumber = old_reserves.borrowernumber)
LEFT JOIN items on (items.itemnumber = old_reserves.itemnumber)

To test the notificationdate and reminderdate, I added data to the old_reserves table, since I have never run notices on my test machine.

Ex:
UPDATE old_reserves
SET notificationdate = "2012-01-29",
reminderdate = "2012-01-29"
WHERE timestamp = "2012-01-29 20:09:34";

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Confirm original bug -- Reports work as expected now!
prove t xt t/db_dependent no different from master.
koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt
reports/reserves_stats.pl