]> git.koha-community.org Git - koha.git/commit
Bug 34562: Update more pop-up windows with consistent footer markup
authorOwen Leonard <oleonard@myacpl.org>
Thu, 17 Aug 2023 10:52:12 +0000 (10:52 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 9 Oct 2023 14:41:25 +0000 (11:41 -0300)
commit6cb78c4d613c38b95036319d33143a48e9a84dd4
treef44a6c4bf7d39092db707d6e7220fee0e48e505e
parent816942f64dc943c474b5d53d84e66bfdd96a4a94
Bug 34562: Update more pop-up windows with consistent footer markup

This patch updates a few more pop-up window templates to standardize the
markup of footer controls. The patch also updates the way catalog.js
triggers the "Add to list" pop-up so that it uses the same
window-opening JS function that similar pages do, since the default
gives us consistent popup features.

To test, apply the patch and perform a catalog search in the staff
interface which will return multiple results.

- Check the box next to one or more results.
- Click the "Add to list" button.
  - Test the various options here: Add to an existing list, a new list,
    or choose "More lists."
  - In each case the pop-up window which appears should have a
    consistent fixed footer with "Save" and "Cancel" buttons.
  - Confirm that these controls can be navigated to using the tab key.
  - Confirm that each one works correctly.

- Go to Administration -> Z39.50/SRU servers -> New SRU server.
  - Click the "Modify" button by the "SRU Search fields mapping" field.
  - Inspect and test the resulting pop-up window.
  - Switch the "Record type" dropdown to "Authority," click the
    "Modify" button again, and test this version of the pop-up window
    too.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/sru_modmapping.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/sru_modmapping_auth.tt
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
koha-tmpl/intranet-tmpl/prog/js/catalog.js