Bug 30825: Remove GetReservesControlBranch in favour of Koha::Item->holds_control_library
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 20 May 2022 14:48:28 +0000 (11:48 -0300)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 22 Sep 2023 15:35:46 +0000 (12:35 -0300)
commit752fb21b4726380980813888a626baa4ebb2613f
tree0dbc0a02faf8ec9ad229a7d8c1c338c9ad22e25f
parente0b5542b077de94d53dc7049a0edbadae5a06ca8
Bug 30825: Remove GetReservesControlBranch in favour of Koha::Item->holds_control_library

This patch removes the GetReservesControlBranch method, and replaces its
uses with the newly introduced method.

To test:
1. Apply this patch
2. Verify that placing holds from the OPAC works
=> SUCCESS: Things work as expected
3. Run:
   $ kshell
  k$ prove t/db_dependent/Reserves* \
           t/db_dependent/Hold* \
           t/db_dependent/Koha/Hold* \
           t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/Reserves.pm
opac/opac-reserve.pl
t/db_dependent/Reserves.t