]> git.koha-community.org Git - koha.git/commit
Bug 28012: Creating numbering pattern: mark mandatory fields required
authorJoonas Kylmälä <joonas.kylmala@iki.fi>
Sat, 3 Sep 2022 11:08:50 +0000 (14:08 +0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 3 Jan 2024 16:27:11 +0000 (17:27 +0100)
commit77e7e11c3a0963bef8d0295eca92f49759f1f3ec
tree92249045739d45e63570e99056fe6845bc6c9be5
parentd4a81e4c2a40ed91513eb2877c79645e9192d32e
Bug 28012: Creating numbering pattern: mark mandatory fields required

If any of these fields were missing, notably the Numbering formula
then saving the new numbering pattern silently failed, it didn't give
any error but it didn't save any new pattern either.

Note that there is a plan to make description field optional, so even
if it currently is mandatory on the DB level we leave it optional
here (and due to people using production DB's in non-strict mode which
allows this to be optional).

To test:
  1) After applying this patch make sure all the 3 fields must be
  filled in
  /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new
  page and it cannot be saved without those.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit a69b5e6ee99478e730be574178c30f950a09532e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt