]> git.koha-community.org Git - koha.git/commit
Bug 12122: TransferSlip should accept both itemnumber and barcode
authorBenjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Tue, 22 Apr 2014 12:09:16 +0000 (14:09 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 5 Mar 2015 10:47:12 +0000 (11:47 +0100)
commit7ba06aad68da2889ea0bf974c2a483e3089e4af4
tree5767563defcd8c4cc4c2e1e073abb6fe1988a7a8
parent45e5afb77b8185eda9151cde7943577201671d17
Bug 12122: TransferSlip should accept both itemnumber and barcode

Added small patch to allow barcode as input in TransferSlip routine, mostly
to allow generating transfer slips where only barcode is present (aka.
javascript).

Test plan:
1) find book with <barcode> and <itemnumber>
2) generate transferslips with both:
  transfer-slip.pl?transferitem=<itemnumber>3967925&amp;branchcode=MPL&amp;op=slip
  transfer-slip.pl?barcode=<barcode>&amp;branchcode=MPL&amp;op=slip
and verify that the generated slips match.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Edit:
 - Added tests in t/db_dependent/Circulation_transfers.t

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Passes tests and QA script.
Works with both itemnumber or barcode as described.
Tested printing transfer slips with the URL examples given
and in the UI.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Circulation.pm
circ/transfer-slip.pl
t/db_dependent/Circulation_transfers.t