]> git.koha-community.org Git - koha.git/commit
Bug 17515: Order Z3950 server by rank and preserve ordering
authorNick Clemens <nick@bywatersolutions.com>
Tue, 27 Oct 2020 15:59:46 +0000 (15:59 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 2 Nov 2020 10:03:09 +0000 (11:03 +0100)
commit7bbf4f7b5fe54a46d2c54a4dc445a0400dfbef23
treea6993d9f1bf6653730cd3ef21f74fc77beb07974
parente1a5fc85a6b829f93d8cc84cc7fb474016e8df61
Bug 17515: Order Z3950 server by rank and preserve ordering

Previously we put all the servers into an object with keys of the server id

This patch converts it to an array of objects to preserve order, and adjusts code to use the array index
where necessary and store the server id within the array

To test:
1 - Add some new Z3950 servers, they don't need to be valid
    FIRST
    SECOND
    THIRD
    FOURTH
2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4
3 - Enable and launch the advanced editor
4 - Click 'Advanced' under search on the left
5 - Note the list displays in the order you entered the servers
6 - Apply patch
7 - Reload
8 - Order is correct
9 - With valid servers, confirm that searching still works and servers can be checked or unchecked to include/remove from results

https://bugs.koha-community.org/show_bug.cgi?id=17515

Signed-off-by: B Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/MetaSearcher.pm
cataloguing/editor.pl
koha-tmpl/intranet-tmpl/lib/koha/cateditor/search.js
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
svc/cataloguing/metasearch