]> git.koha-community.org Git - koha.git/commit
Bug 20854: (QA follow-up) Improve readability
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 16 Mar 2021 19:50:34 +0000 (16:50 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 21 Apr 2021 08:51:29 +0000 (10:51 +0200)
commit7c3c066714ce568e507348f1e3a9a6b7db0c4815
tree7e435747ec80083653c7b8dd747575e934b5a668
parentc71dda04c605b68b439e1a0ea3132447eeb28b45
Bug 20854: (QA follow-up) Improve readability

The logout_cas method does too little tasks. In this case, I consider we
should not split it into a separate method. As the CAS implementation
lacked tests, it made sense to do it like this, so it is testable. But
now we have higher-level tests for logout_cas, we can bake the behavior
inside of it, and it is testable.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Auth_with_cas.pm