]> git.koha-community.org Git - koha.git/commit
Bug 27180: Update fines on holidays
authorNick Clemens <nick@bywatersolutions.com>
Wed, 9 Dec 2020 15:39:09 +0000 (15:39 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 19 Jan 2021 15:03:34 +0000 (16:03 +0100)
commit80e1b4e66f01a07cad9bf37625d879f649edf52a
treeacd7f53698b06f656df3bd6c598efc732e7c892d
parent5f595aab028d0d5835b8e7ed3ffaf534e83c0db0
Bug 27180: Update fines on holidays

This patch removes code that prevents fines from being update on holidays.
The fines are already being calculated, and that takes the calendar into account if
needed, so fines won't be assessed on holidays if they shouldn't.

To test:
 1 - set finesCalendar to 'ignore'
 2 - Checkout an item due yesterday
 3 - Ensure circ rules have a fine amount set
 4 - Make today a holiday
 5 - run fines.pl
 6 - No fine assessed
 7 - Apply patch
 8 - run fines.pl
 9 - Fine assessed!
10 - set finesCalendar to 'use'
11 - checkout an item, due yesterday
12 - run fines.pl
13 - no fine assessed

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
misc/cronjobs/fines.pl