]> git.koha-community.org Git - koha.git/commit
Bug 21786: Make balance and credits endpoints handle library_id
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 9 Nov 2018 19:29:43 +0000 (16:29 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 8 Jan 2019 15:50:50 +0000 (15:50 +0000)
commit814078ab401900a118558b828a9dc796c9a81c87
tree0025b1bb94d32c8b02053e346947bfd3dd509ad7
parent4c742b59f75cf56a844b0b8eed1b15a0313a7783
Bug 21786: Make balance and credits endpoints handle library_id

This patch:
- Adds the branchcode <-> library_id mapping in the controller
- Adds 'library_id' to the credit and account_line definitions
- Makes add_credit handle the library_id param, passing it to the
  underlying $account->add_credit method.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> FAIL: Tests fail, because library_id is not mapped
(balance) and because it is not handled when adding a credit.
- Apply this patch
- Run:
  k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/REST/V1/Patrons/Account.pm