]> git.koha-community.org Git - koha.git/commit
Bug 29157: Date and Datetime attributes cannot be set NULL
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 7 Oct 2021 18:28:40 +0000 (15:28 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 15 Oct 2021 09:34:26 +0000 (11:34 +0200)
commit868e02bfab5ded8759e85cadb7d6d14ec2c2773d
treee9a41e78650cfea18a0cf958c6cbabc7c16deda8
parent9a8563d0744c1da5798322a11ea8c87744cc4d61
Bug 29157: Date and Datetime attributes cannot be set NULL

This patch makes Koha::Object->attribute_from_api allow setting
attributes the undef value. The original implementation passed the value
directly to dt_from_string, which made the attribute be set the current
date.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail! Our code is buggy!
3. Apply this patch
4. Repeat 2
=> SUCCESS! Fix fixed this thing!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Eric Phetteplace <phette23@gmail.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Object.pm