]> git.koha-community.org Git - koha.git/commit
Bug 16873: Improve renewal error messages on self check
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 19 Aug 2016 11:01:32 +0000 (12:01 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Tue, 29 Nov 2016 17:44:09 +0000 (17:44 +0000)
commit8dce1cde3a8b1d0cd742f26545aa1d09e4ff63df
treed8886b8c0bb5f0dac196035da1de5a4a23d83764
parent2d769cd5081de0572f9b59e3dbcb99f309caf0a2
Bug 16873: Improve renewal error messages on self check

When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.

To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.

Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check out an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check out an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check out an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
opac/sco/sco-main.pl