]> git.koha-community.org Git - koha.git/commit
Bug 18947: LDAP - do not assume anonymous bind if no user or password
authorNick Clemens <nick@bywatersolutions.com>
Wed, 13 Dec 2017 13:27:36 +0000 (13:27 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 20 Aug 2018 14:40:13 +0000 (14:40 +0000)
commit8eed0466381435a0426fe9c2ea75fa295d906533
tree5e3b68507d40d5acb2a9ecc3b5296b2ade40cbcc
parent88d3865168a83aa7e69999ab3336b238a2ed14ff
Bug 18947: LDAP - do not assume anonymous bind if no user or password

To test:
Ideally tested on a working ldap server with bind by auth and no
anonymous bind
1  - Define an LDAP config with bind by auth
2  - Don't define user/pass
3  - Define anonymous_bind = 0
4  - Attempt bind by auth
5  - Error is something like:
LDAP search failed to return object : XXXXXXXXX: LdapErr: XXXX-XXXXXX,
     comment: In order to perform this operation a successful bind must
     be completed on the connection., data 0, v2580 at
     /usr/share/koha/lib/C4/Auth_with_ldap.pm line 102.
6  - Define user/pass
7  - Now bind by auth should work
8  - remove user/pass
9  - Apply patch
10 - Attempt again
11 - Bind by auth shoudl succeed

prove -v t/db_dependent/Auth_with_ldap.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Auth_with_ldap.pm
t/db_dependent/Auth_with_ldap.t