]> git.koha-community.org Git - koha.git/commit
Bug 22030: Use preference to determine username sent to overdrive
authorNick Clemens <nick@bywatersolutions.com>
Wed, 19 Dec 2018 17:53:08 +0000 (17:53 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 8 Jan 2019 13:59:46 +0000 (13:59 +0000)
commit96adab7af8999da7f351169e1265d4be5e59742f
tree2846c4839eea6bce62b98ff628340c37f336dab3
parent482b323da1e18324941963359b9a1bd96f297c44
Bug 22030: Use preference to determine username sent to overdrive

Overdrive configuration generally defaults to cardnumber, however, they
have confirmed that some libraries use usernames. We need to allow for
both scenarios.

To test:
1 - Have an OverDrive account setup with SIP authentication
    Note: You can apply for a testing account at developer.overdrive.com
    and setup an environment
2 - Fill in all your OverDrive system preferences
3 - Test with a patron whose username is their cardnumber
4 - Confirm their overdrive account tab on opac loads
5 - Change the username to be another value like "borked_wont_work"
6 - Note the overdrive account tab won't load
7 - Apply patch, update database, not new system preference
OverDriveUsername (default to 'cardnumber)
8 - Note the OD account loads successfully
9 - Change the system preference to 'user name' - the account load fails

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
installer/data/mysql/atomicupdate/bug_22030_add_OverDriveUsername_system_preference.perl [new file with mode: 0644]
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
opac/svc/overdrive