]> git.koha-community.org Git - koha.git/commit
Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Wed, 17 Feb 2021 12:28:03 +0000 (14:28 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 4 Mar 2021 15:18:42 +0000 (16:18 +0100)
commit9b5913d308e4aa03306c5275d0e638e922a6db32
tree5f703f2296e9be7415529cfbaae78a20d260dfb3
parentfbef5478325bbc71064f9ecb3c4c50eaed0b223d
Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred

Items that are attached to a hold and being transferred (found = T) is
final decision and you cannot checkout those to other patrons.

To test (if you have applied all patches from bug 25690):
 1) prove t/db_dependent/SIP/Transaction.t => passes

To test (if you don't have all patches):
 1) Create hold and set pickup library to something else where the
    item is at
 2) Return the item and it should confirm the hold and start transfer
 3) Apply this patch
 4) Try to checkout this item now to some other patron via SIP2 and
    notice it doesn't allow it
 5) Revert this patch
 6) Notice you can now checkout somebody else's hold that is being transferred!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/SIP/ILS/Item.pm