]> git.koha-community.org Git - koha.git/commit
Bug 22049: (follow-up) Remove leftover variable
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 31 Dec 2018 11:28:03 +0000 (08:28 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 25 Jan 2019 20:46:48 +0000 (20:46 +0000)
commita243104bf77e3a3905b6fc55bc9ee883826fc083
tree7330a91d4470913f7ac6956ed8c9b354bd4b77f3
parent603e619e0cdbe6ddbf39ed54adc5e2bda168ec6e
Bug 22049: (follow-up) Remove leftover variable

The $circControlBranch variable was originally set to be used to pick
the right dropbox branch. It was only used in MarkIssueReturned, to get
the right Koha::Calendar object. As this responsability was moved top to
the AddReturn caller, and the fact that _GetCircControlBranch is
actually used for fines rules, there's no use for it in this context.
And it was left on the previous patch as a mistake.

To test:
- Make sure the variable is not actually used:
  $ git grep '$circControlBranch'
=> SUCCESS: removed variable is not actually used.
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Circulation.pm