]> git.koha-community.org Git - koha.git/commit
Bug 26922: Better error handling in SendAlerts
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 19 Nov 2020 16:09:47 +0000 (13:09 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 20 Nov 2020 14:44:20 +0000 (15:44 +0100)
commita9e3db201e1863b30ac0e2654d82a15f0f8e44c0
tree0e33052701c69f2f908c08552e9be127047a6d23
parent279ce72e4ced3ca191a8ee4e109c28df169dfc20
Bug 26922: Better error handling in SendAlerts

This patch makes SendAlerts display a better error message when sending
fails.

To test:
1. Set KohaAdminEmailAddress to admin@example.org
2. Edit a vendor, set a valid email address
3. Create a new basket, a new order. Send the basket
=> FAIL: As you did not configure a valid SMTP server, the email is not sent and logs displayed "unable to establish SMTP connection to (localhost) port 25", with the stracktrace.
4. Apply this patch and reload all
5. Repeat 3
=> SUCCESS: A simpler message is displayed, the stacktrace remains in
the logs
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Letters.pm