]> git.koha-community.org Git - koha.git/commit
Bug 21875: Handling subject line in Letters.pm
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 23 Nov 2018 10:36:49 +0000 (11:36 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Wed, 27 Feb 2019 14:14:21 +0000 (09:14 -0500)
commitaae5e558465c365d9f857ad6f7b4aab46896a7da
tree9603066a3815d156e2d545366f74431ab96c5e16
parentf9162c2e5e7cd8eff0a9e96572156309f296fd41
Bug 21875: Handling subject line in Letters.pm

The variable name $utf8 is very misleading: it contains MIME-Header encoding.
$message->{subject} comes from the database and is in perl internal format;
it should NOT be decoded as a MIME-Header.
After encoding to MIME-Header, previously another (useless) encoding to
UTF-8 was done. Since the string is plain ASCII, this is useless and
theoretically wrong. We should stay in MIME-Header.

Test plan:
See Bugzilla comment5.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Letters.pm