]> git.koha-community.org Git - koha.git/commit
Bug 32983: ERM - Retrieve AVs from an endpoint
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 16 Feb 2023 13:38:46 +0000 (14:38 +0100)
committerMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Fri, 3 Mar 2023 12:22:12 +0000 (12:22 +0000)
commitac3ec38f5f05a745a6d7c3e307d0d45df619b3cc
treee7173fb3a688b408eb367d08851c9335bf48995d
parent4eee0de8c7dea008038f3289c4c06d7ea80983ac
Bug 32983: ERM - Retrieve AVs from an endpoint

Bug 32981 let us retrieve the authorised values from a REST API route,
instead of injecting them from the template. Let us that for the ERM module!

Test plan:
You will notice a "Loading" screen when refreshing the ERM module
Then you should not notice any other UI changes. Dropdown list should be
populated like before this patch.

Some technical notes:
I am expecting this to be slower than before, but it feels better to use
a REST API route to retrieve the AV
Future improvement will be to lazy load the AVs, to speed up the landing
page. However it needs more changes, and this gets big enough.
I would like to see a follow-up that move the code from ERM/Main.vue to
the authorised value store (I've failed at that), but that should
certainly be done after the lazy loading is implemented anyway)

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5d8c6a36b8647aa33945e4e6e9b28e511cd433bb)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
19 files changed:
koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt
koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementLicenses.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementRelationships.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesList.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesFormAdd.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormAdd.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UserRoles.vue
koha-tmpl/intranet-tmpl/prog/js/vue/fetch/api-client.js
koha-tmpl/intranet-tmpl/prog/js/vue/fetch/authorised-values.js [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/js/vue/messages.js
koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts
koha-tmpl/intranet-tmpl/prog/js/vue/stores/authorised-values.js [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/js/vue/stores/authorised_values.js [deleted file]
koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js