]> git.koha-community.org Git - koha.git/commit
Bug 23289: Quote new 'rows' MariaDB reserved word
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 1 Sep 2019 19:26:02 +0000 (15:26 -0400)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 6 Sep 2019 12:17:48 +0000 (13:17 +0100)
commitaede6896dd6ebc660894bcde117ccd213e2c3de6
tree4a6b1bc6acddcd7231fd732c91d29e1d3a7bd202
parent60ce66b6b658bfbe0d9ca459afc673042c7a854f
Bug 23289: Quote new 'rows' MariaDB reserved word

Since MariaDB 10.2.4 rows is a reserved word:
https://mariadb.com/kb/en/library/mariadb-1024-release-notes/

"""
New reserved word: ROWS. This can no longer be used as an identifier
without being quoted.
"""

Test plan:
With MariaDB >= 10.2.4, create a new label template.
Also, prove t/db_dependent/Labels/t_Template.t

Without this patch you will get the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, creator, template_code, page_height,

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Creators/Template.pm