]> git.koha-community.org Git - koha.git/commit
Bug 22818: (follow-up) Respond to feedback
authorAndrew Isherwood <andrew.isherwood@ptfs-europe.com>
Thu, 15 Oct 2020 13:57:19 +0000 (14:57 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 11 Nov 2020 07:35:10 +0000 (08:35 +0100)
commitafd13b6a9b2b980872a0dc18d3fcc207f2f2cd3e
treeb084f99423362116a713348b5d43df1e648aeac1
parent30af45ccf126979c0bddcc69992b7e33516dfea0
Bug 22818: (follow-up) Respond to feedback

This commit fixes this bug, it was broken in a number of ways.

Fixes include:

- Added necessary config block in C4::Letters to enable the TT notice
syntax introduced in an earlier commit to work
- Changed template variables to refer to singular objects rather than
multiple e.g. borrowers -> borrower
- Fixed missing / misnamed variables

This commit also implements the additional syspref checks suggested by
Katrin in comment #87

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Letters.pm
Koha/Illrequest.pm
api/v1/swagger/definitions/library.json
installer/data/mysql/atomicupdate/bug_22818_add_ill_notices.perl
koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt