]> git.koha-community.org Git - koha.git/commit
Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm
authorMark Tompsett <mtompset@hotmail.com>
Wed, 5 Nov 2014 08:06:42 +0000 (03:06 -0500)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 7 Nov 2014 18:06:47 +0000 (15:06 -0300)
commitba3c3df6f951a363412d171f3a995d48a4f3b096
treef15c4b81a73be000f189e0b9768f0616aac88d22
parentb27c2e6026cb16d8a77f0b8aa90a9d9e121b1784
Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm

While testing a bug, warnings in the opac error log were
building up due to a particular line in C4::Auth. After
reviewing the code, it was discovered that removal of the
OpacMainUserBlockMobile system preference created this.

Since the system preference no longer exists, and is not
used, the line was deleted from C4/Auth.pm to prevent this
warning from occuring.

TEST PLAN
----------
1) Go to any OPAC page.
2) Check your opac error log.
   -- there should be something about uninitialized values
      used in C4/Auth.pm around line 443.
3) Apply the patch
4) Refresh the page.
   -- that same error should not be triggered.
5) prove -v t/db_dependent/Auth.t
   -- this runs the get_template_and_user function
      which had the parameter removed.
6) run the koha qa test tools

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Auth.pm