]> git.koha-community.org Git - koha.git/commit
Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsO...
authorAlex Buckley <alexbuckley@catalyst.net.nz>
Wed, 24 Jul 2019 11:33:48 +0000 (11:33 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 2 Nov 2020 10:03:08 +0000 (11:03 +0100)
commitbc0c687ca5e20447ff72917cf1c2734f580ac7a2
treeb6b7c1693c9ac794d472b36b2f8590d2441b1374
parent3fd7d5974a0952ea4cf677ca83c18db46e637b5a
Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions

As CanBookBeReserved() was failing as $patron and and $biblio were not
instantiated I fixed that up.

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

Sponsored-By: Catalyst IT
Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Reserves.pm