Bug 35535: Allow for cancellation of holds with or without a reason
authorLucas Gass <lucas@bywatersolutions.com>
Wed, 17 Jan 2024 15:45:53 +0000 (15:45 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Mon, 29 Jan 2024 11:25:07 +0000 (12:25 +0100)
commitc1bf46d1e77c4b4bc8d6c6c1df0a5d5d9a953bfd
tree9029c7926607d107cd45058dde3a7358f85263ec
parent898da9e4eb08f74cff250c44ae6f1252d0fe02f6
Bug 35535: Allow for cancellation of holds with or without a reason

TO TEST:
1. Have a waiting hold on a particular barcode
2. Have at least 1 HOLD_CANCELLATION auth value
3. Check in the barcode and try to cancel the hold on the modal while
   selecting a reason.
=> SUCCESS: You can cancel a hold when selecting a reason.
4. Repeat 1-3 but not selecting any reason.
=> SUCCESS: Hold cancelled correctly.
5. Delete all HOLD_CANCELLATION auth values.
6. Repeat Try 1-3
=> SUCCESS: No reason displayed
=> FAIL: Cancelling does nothing. There's an error in the browser
   inspector
7. Apply this patch
8. Repeat 1-3
=> SUCCESS: No reason displayed
=> SUCCESS: Cancelling works
9. Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: amended the test plan to make it clearer
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt