]> git.koha-community.org Git - koha.git/commit
Bug 11375: Improve patrons permissions display
authorOwen Leonard <oleonard@myacpl.org>
Thu, 24 May 2018 13:48:48 +0000 (13:48 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 11 Mar 2019 13:05:19 +0000 (13:05 +0000)
commitd9be495c36384d4a003e3b3b8938a75584df599d
treea801f4d3a5eabf216d63f8c92b2ab4c7d5e42b9c
parentc3f28829e50690da8fdfa104cdbacb3d0354da18
Bug 11375: Improve patrons permissions display

This patch updates the patron permissions interface in order to
emphasize permission descriptions (which can be translated) over
permission code (which cannot).

The tree structure (and jQuery plugin) is removed, and permissions are
displayed in a table-like way. Sub-permissions are shown or hidden with
a link.

A free-text filter is added to the top for narrowing the list by
keyword.

Save and cancel buttons are now in a floating toolbar.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache if necessary.

 - Open the "Set permissions" page for any patron.
 - Confirm that the filter works correctly to show only lines which
   match your entry
   - Note that the superlibrarian line stays visible all the time. This
     is to make it clearer that sub-permissions cannot be selected if
     superlibrarian is checked.
 - Check the superlibrarain "hint" text for clarity.
 - Test the show/hide controls.
 - Test that checking a "parent" permission displays the
   sub-permissions.
 - Test that the toolbar with Save and Cancel floats when scrolling.
 - Test that changing and saving permissions works correctly.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
20 files changed:
koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.treeview.pack.js [deleted file]
koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
koha-tmpl/intranet-tmpl/prog/css/treeview/images/file.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/folder-closed.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/folder.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/minus.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/plus.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-black-line.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-black.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-default-line.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-default.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-famfamfam-line.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-famfamfam.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-gray-line.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-gray.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-red-line.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-red.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/css/treeview/jquery.treeview.css [deleted file]
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt